Skip to content

PagerDuty component required an optional field #17651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2025
Merged

PagerDuty component required an optional field #17651

merged 2 commits into from
Jul 16, 2025

Conversation

@jverce
Copy link
Contributor

@jverce jverce commented Jul 16, 2025 •
edited by coderabbitai bot
Loading

WHY

The assigneeIds prop from the pagerduty-trigger-incident component was marked as required even though the PagerDuty API does not require it (as long as the request includes an escalation policy ID).

Summary by CodeRabbit

  • New Features

    • Updated the incident trigger action to allow incidents to be created without specifying assignees.

  • Chores

    • Incremented the action and package versions to reflect the latest updates.

@jverce
PagerDuty component required an optional field
c915eab 
The `assigneeIds` prop from the `pagerduty-trigger-incident` component
was marked as required even though the PagerDuty API does not require
it (as long as the request includes an escalation policy ID).
@jverce jverce self-assigned this Jul 16, 2025
@jverce jverce added bug Something isn't working javascript Pull requests that update Javascript code tracked internally Issue is also tracked in our internal issue tracker prioritized Prioritized issue actions labels Jul 16, 2025
@vercel
Copy link

vercel bot commented Jul 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Jul 16, 2025 7:05pm

@vercel
Copy link

vercel bot commented Jul 16, 2025

@jverce is attempting to deploy a commit to the Pipedreamers Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 16, 2025 •
edited
Loading

Walkthrough

The version of the PagerDuty trigger incident action was incremented from "0.0.2" to "0.0.3". Additionally, the assigneeIds property in the action's configuration was made optional by adding the optional: true flag. The package version in package.json was also updated from 0.3.8 to 0.3.9.

Changes

File(s) Change Summary
components/pagerduty/actions/trigger-incident/trigger-incident.mjs Bumped action version to "0.0.3"; made assigneeIds property optional
components/pagerduty/package.json Bumped package version from 0.3.8 to 0.3.9

Poem

A hop and a skip, the version climbs high,
"Assignee IDs" now optional—no need to ask why!
The PagerDuty bunny leaps with glee,
For 0.0.3 is as light as can be.
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c915eab and 6059b84.

📒 Files selected for processing (1)
  • components/pagerduty/package.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • components/pagerduty/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Lint Code Base
  • GitHub Check: Verify TypeScript components
  • GitHub Check: Publish TypeScript components

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pipedream-component-development
Copy link
Collaborator

pipedream-component-development commented Jul 16, 2025

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

@pipedream-component-development
Copy link
Collaborator

pipedream-component-development commented Jul 16, 2025

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

andrewjschuang
andrewjschuang previously approved these changes Jul 16, 2025
View reviewed changes
@jverce jverce merged commit 0716ad5 into PipedreamHQ:master Jul 16, 2025
10 of 11 checks passed
@jverce jverce deleted the jay/tec-49-page-on-call-for-dropbox-webhook-issues branch July 16, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andrewjschuang andrewjschuang andrewjschuang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jverce jverce

Labels

actions bug Something isn't working javascript Pull requests that update Javascript code prioritized Prioritized issue tracked internally Issue is also tracked in our internal issue tracker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jverce @pipedream-component-development @andrewjschuang